(templates): Stop hydrating with requestIdleCallback#667
Merged
Conversation
juanpprieto
changed the title
juanpprieto
changed the title
lordofthecactus
approved these changes
Mar 10, 2023
Contributor
lordofthecactus
left a comment
lordofthecactus
left a comment
There was a problem hiding this comment.
Interesting thread 💯
frandiox
approved these changes
Mar 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hydrating with
requestIdleCallbackcan cause the following issuesThanks to @developit for highlighting all the above 🙏🏼
TLDR;
https://shopify.slack.com/archives/C04SRS2C10A/p1678401031037239
WHAT is this pull request doing?
Avoid waiting for an idle frame to hydrate the app.
HOW to test your changes?
Demo store should be interactive after this change.
Checklist