Fix support for derived classes of Liquid::Raw#148
Merged
Conversation
peterzhu2118
approved these changes
Mar 12, 2021
dylanahsmith
added a commit
that referenced
this pull request
Mar 17, 2021
(cherry picked from commit a92424d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#135 introduces a regression for child classes of Liquid::Raw, since it compiles them as if they are Liquid::Raw. See the included regression test for an example.
Solution
Add a conditional to only compile the Liquid::Raw tag to a raw write instruction if the class is equal to Liquid::Raw (i.e. not a subclass)