Skip to content

Add liquid_vm_next_instruction to reduce duplication#72

Merged
dylanahsmith merged 1 commit into
masterfrom
vm-next-instruction
Oct 6, 2020
Merged

Add liquid_vm_next_instruction to reduce duplication#72
dylanahsmith merged 1 commit into
masterfrom
vm-next-instruction

Conversation

@dylanahsmith
Copy link
Copy Markdown
Contributor

@dylanahsmith dylanahsmith commented Oct 6, 2020

This is another refactor I extracted from #59

I've added a liquid_vm_next_instruction function to reduce duplication for code iterating instructions by using it for both Liquid::C::BlockBody#remove_blank_strings and Liquid::C::BlockBody#nodelist. This way I can further leverage it for variable error handling.

@dylanahsmith dylanahsmith merged commit f683ac8 into master Oct 6, 2020
@dylanahsmith dylanahsmith deleted the vm-next-instruction branch October 6, 2020 17:28
@dylanahsmith dylanahsmith mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanahsmith @peterzhu2118