Only use MethodLiteral in condition expressions#1300
Merged
Conversation
macournoyer
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MethodLiteral literal value was added in #592 which described it as a hacky solution:
One way in which it is hacky is that it is only relevant for boolean comparison equality expressions and isn't relevant for all expressions.
In liquid-c (Shopify/liquid-c#60), I would like Liquid::Expression.parse to return a Liquid::C::Expression object that can be rendered more efficiently and I would like to avoid coupling this work to these
MethodLiteralobjects.Solution
Add a
Liquid::Condition.parse_expressionmethod that wrapsLiquid::Expression.parseso that it will return aMethodLiteralobject foremptyorblankliterals and will otherwise delegate toLiquid::Expression.parse. This way the values for these literals that are returned byLiquid::Expression.parsecan just be the empty strings thatMethodLiteral#to_liquidreturns.