Fix strict parsing of find variable with a name expression#1317
Merged
Conversation
pushrax
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in Shopify/liquid-c#60 (comment) the strict parser doesn't support finding a variable with an expression key like
{{ [x] }}. This seems like a bug, since I don't believe it was the intention of the strict parser to remove any features. This is also an incompatibility with liquid-c, where its strict parser has allowed this type of dynamic find variable.Solution
I've added a regression test, which fails with the syntax error we were seeing without the corresponding fix.
I also turned Liquid::Parser#variable_signature into a
variable_lookupsmethod that no longer assumes the it starts with a dot lookup. I've refactored Liquid::Parser#expression to use a case statement, then added the new:open_squarecase.