Implement raw tag parsing in BlockBody#1378
Closed
peterzhu2118 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Won't we have that special case either way? Since we want to serialize the body as a raw string for the raw tag, rather than as a normal liquid block. The advantage of this liquid and liquid-c change isn't clear without additional context about the follow-up changes that will use this. |
macournoyer
reviewed
Jan 4, 2021
| def parse(tokens) | ||
| @body = +'' | ||
| while (token = tokens.shift) | ||
| if token =~ FullTokenPossiblyInvalid && block_delimiter == Regexp.last_match(2) |
Contributor
There was a problem hiding this comment.
Should remove FullTokenPossiblyInvalid from this class, since it's now in BlockBody
Contributor
Author
|
The alternative to this PR is Shopify/liquid-c#135 which writes the raw tags directly as an instruction. |
Contributor
|
Would Shopify/liquid-c#135 also replace Shopify/liquid-c#134? |
Contributor
Author
|
Yeah. Shopify/liquid-c#135 does basically this PR + Shopify/liquid-c#134 but implemented differently (without modifying liquid implementation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing serialization, I noticed that the
Rawtag did not use aBlockBodyfor storing its body which is different than how other blocks work. This makes serialization difficult as this becomes a special case that needs to be handled.This PR adds a parsing mode for raw tags inside
BlockBodythat parses for raw tags.