Conversation
ggmichaelgo
approved these changes
Oct 23, 2024
This was referenced Oct 28, 2024
andrykonchin
pushed a commit
to andrykonchin/liquid
that referenced
this pull request
Feb 24, 2025
* Speed up lexing * Bump msrv to 3.0 (from 2.7) * Normalize test for ruby-head compat * Fix bug when parsing negative numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up lexing by making using of some new
strscanfeatures when available, namelyStringScanner#peek_byte.Benchmarks
Local
Comparison of
be rake benchmark:stricton Ruby 3.4:72.452 (± 4.1%) i/s (13.80 ms/i) - 2.170k in 30.029157s92.409 (± 1.1%) i/s (10.82 ms/i) - 2.772k in 30.002144sProduction
I ran the two in A/B style against some production traffic. The following measures
Liquid::Template.parsewith the new lexer:1: Old
2: New
To make this work smoothly with CI and such, I needed to bump min version to Ruby 3.0 and remove Gemfile.lock, which need to be updated anyway.