uninitialized constant RubyLsp::RuboCop::Cop (NameError)

[abrisse]

Description

Ruby LSP Information

The version 1.17.0 of the gem rubocop defines a new module RubyLsp::Rubocop. (link) that breaks several lines of code of the gem ruby-lsp.

Reproduction steps

In my Gemfile.lock:

• rubocop (1.70.0)
• ruby-lsp (0.23.4)

1. Start the Ruby LSP using VSCode
2. It fails with the following message:

Error processing initialized: .bundle/ruby/3.1.0/gems/ruby-lsp-0.23.4/lib/ruby_lsp/requests/support/rubocop_runner.rb:86:in
'initialize':uninitialized constant RubyLsp::RuboCop::Cop (NameError)

Fix

Replace all the Rubocop references within the namespace RubyLsp using the top-level namespace operand :: That's already the case on some instructions but not everywhere.

So basically RuboCop::Cop should be replaced by ::RuboCop::Cop. I will try to provide a PR.

[vinistock]

Thank you for the issue and the PR, but I'm not 100% sure that this is all that's needed to fix the conflicts.

I wrote here a bit about the issues that may happen with RuboCop pushing an add-on that conflicts with our internal implementation rubocop/rubocop#13628 (comment).

We will need a bit more coordination to make this transition work smoothly.

[abrisse]

I see I didn't get the big picture. Appreciate the quick feedback thanks.