Add rename support for constants#2626
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
16b741b to
f15a0af
Compare
f15a0af to
ae8a87a
Compare
❌ Deploy Preview for ruby-lsp failed.
|
st0012
reviewed
Oct 1, 2024
ae8a87a to
a40caf8
Compare
Contributor
st0012
reviewed
Oct 2, 2024
Contributor
|
Should we allow people to change namespaces with this? e.g. renaming It 'works' but does complicate some things. |
andyw8
reviewed
Oct 2, 2024
andyw8
reviewed
Oct 2, 2024
a40caf8 to
f0cbd0d
Compare
andyw8
reviewed
Oct 2, 2024
f0cbd0d to
c60e050
Compare
Contributor
|
🤔 If a constant is already defined, should we prevent someone to renaming to that constant? |
andyw8
reviewed
Oct 2, 2024
c60e050 to
21f56af
Compare
Member
Author
Added a check for this. Great catch. |
st0012
approved these changes
Oct 2, 2024
Member
st0012
left a comment
There was a problem hiding this comment.
I still prefer assigning attributes to ivars. But it's a small detail that can be discussed later.
21f56af to
377e988
Compare
andyw8
approved these changes
Oct 2, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Closes #57
This PR adds rename support for constants, modules and classes.
Implementation
ReferenceFinder. This is essentially a simplified copy of our declaration listener. I believe that either the declaration listener can be modified to support collecting references or we can extract some abstraction for both to use. However, I would like to start with a copy, so that we can see the patterns emerge as we add support for more renamesAutomated Tests
Added tests.