Add Prepare Rename Request#2894
Merged
Merged
Conversation
Contributor
|
Nice! Do you know if the "The element can't be renamed" message can be customized? |
Contributor
Author
|
To set a customized message, the error code and message need to be included in the response. |
vinistock
added
server
Graphite App
vinistock
reviewed
Nov 27, 2024
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Great work! This is essentially ready to ship, I just left a few minor comments to adjust.
vinistock
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2854
Implementation
If the position of the
prepareRenamerequest corresponds to a node of typePrism::ConstantReadNode,Prism::ConstantPathNode, orPrism::ConstantPathTargetNode, the range of the node will be returned; otherwise, it will return nil.Automated Tests
Added new tests
Manual Tests
Screencast.from.21-11-24.10.34.25.PM.IST.webm