Fix singleton class ancestor chain for intermediate classes#709
Merged
Conversation
Process `def self.method` definitions in the convergence loop instead of handle_remaining_definitions. This ensures get_or_create_singleton_class runs while Unit::Ancestors items can still be processed, allowing the singleton ancestor chain to cascade upward through parent classes. Previously, a class with no singleton definitions (e.g., `class Bar < Foo` with no `def self.`) never got a `Bar::<Bar>` singleton, breaking the ancestor chain for `Baz::<Baz>` → `Bar::<Bar>` → `Foo::<Foo>`.
st0012
force-pushed
the
fix-singleton-ancestor-chain
branch
from
a316f20 to
e142708
Compare
vinistock
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
Summary
def self.methoddefinitions are now processed in the convergence loop instead ofhandle_remaining_definitionsget_or_create_singleton_classpushesUnit::Ancestorsfor newly created singletons, triggering upward cascade through the inheritance chainRuby creates singleton classes on demand and cascades upward — when
Baz.singleton_classis accessed,Bar.singleton_classandFoo.singleton_classare created too. The problem was that singleton creation happened inhandle_remaining_definitions(after the convergence loop), soUnit::Ancestorsitems pushed byget_or_create_singleton_classwere never processed. Movingdef self.methodinto the convergence loop lets the cascade happen naturally.