Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

[Bug]: shopify theme serve - adding a file after deletion does not trigger hot reload #2447

@mgmanzella

Description

@mgmanzella

Please confirm that you:

What type of project are you working on?

theme

Expected behavior

Discovered this issue while working on a bug fix for this issue for triggering hot reloading on file delete: #2342

When re-adding a deleted file, it appears to not get uploaded and tracked by the watcher. On delete and re-add I expect the browser to reload with the liquid asset I just re-added.

Actual behavior

When I delete and re-add a file, it doesn't get picked up by the watcher and re-add the liquid asset in the browser. It still appears to be missing. It only appears again after restarting the theme dev server

Stack trace

No response

Reproduction steps

  1. Run shopify theme serve locally
  2. Delete a liquid asset you see rendered on the current page in a browser (like announcement-bar.liquid)
  3. Refresh the page and see that asset not found
  4. Re-add the asset you just deleted
  5. Refresh the page and see it never gets re-added

Operating System

Mac OS

CLI version (run shopify version if you're not sure)

2.19.0

Shell

No response

Ruby version (run ruby -v if you're not sure)

ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.arm64e-darwin21]

What language and version are you using in your application?

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions