This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Conversation
karreiro
reviewed
Oct 21, 2022
Contributor
karreiro
left a comment
There was a problem hiding this comment.
Great stuff, @mgmanzella! 🚀 LGTM and works on Windows as well :)
What do you think about handling 7z as a fallback of the zip command?
Some Linux distributions might not have the zip command, but they may have 7z, so we'd cover this case.
Thank you for this PR!
288ed4a to
1e61b08
Compare
mgmanzella
commented
Oct 21, 2022
Contributor
Author
mgmanzella
left a comment
There was a problem hiding this comment.
What do you think about handling 7z as a fallback of the zip command?
great idea!! @karreiro i made changes to do this and left some comments for you to look at 🙏
karreiro
reviewed
Oct 24, 2022
Contributor
karreiro
left a comment
There was a problem hiding this comment.
Thank you for the updates, @mgmanzella!
I've added a minor comment about the which method :)
d303c4d to
967eb55
Compare
mgmanzella
commented
Oct 25, 2022
karreiro
approved these changes
Oct 26, 2022
Contributor
karreiro
left a comment
There was a problem hiding this comment.
Thanks a lot, @mgmanzella! LGMT and works greatly too!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #2513
WHAT is this pull request doing?
Modifies the package command to use a 7zip to zip files when
theme packageis run on WindowsHow to test your changes?
Machine Setup
The test steps should be run on all platforms.
Mac
Windows
shopify.batname in the bin folder of the repo toshopify-dev.batLinux
TODO
Test Steps
shopify-dev theme initshopify-dev theme package <path/to/theme>cd <theme-name>shopify-dev theme packagePost-release steps
7zipfor theme package on windowsUpdate checklist