This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Add new changes from CLI 3 (packages/cli-kit/assets/cli-ruby)#2729
Merged
Add new changes from CLI 3 (packages/cli-kit/assets/cli-ruby)#2729
packages/cli-kit/assets/cli-ruby)#2729Conversation
Poitrin
requested review from
a team,
Arkham and
matteodepalo
and removed request for
a team
Poitrin
force-pushed
the
include-changes-from-cli-3
branch
2 times, most recently
from
aaaef74 to
59775dc
Compare
Poitrin
force-pushed
the
include-changes-from-cli-3
branch
from
59775dc to
d377d0b
Compare
Poitrin
requested review from
alvaro-shopify
and removed request for
Arkham and
matteodepalo
mgmanzella
approved these changes
Feb 16, 2023
Contributor
mgmanzella
left a comment
mgmanzella
left a comment
There was a problem hiding this comment.
thank you @Poitrin !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
All fixes to embedded Ruby CLI should be added to both repos and new features only in the CLI3 repo.
This is because we should give support to the old CLI repo until the sunset date on 31th May.
WHAT is this pull request doing?
Adds new changes from CLI 3 (
packages/cli-kit/assets/cli-ruby)Update checklist