Attempt to fix stringio incompatibility with Ruby 3.3 (deployment error)#145
Merged
rochlefebvre merged 1 commit intomainfrom May 13, 2024
Merged
Attempt to fix stringio incompatibility with Ruby 3.3 (deployment error)#145rochlefebvre merged 1 commit intomainfrom
rochlefebvre merged 1 commit intomainfrom
Conversation
4d26995 to
4d969a3
Compare
devanandersen
approved these changes
May 13, 2024
Contributor
devanandersen
left a comment
There was a problem hiding this comment.
Makes sense to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Which is very close to ruby/stringio#54, fixed as part of stringio 3.0.7, a release that adds support for Ruby 3.3.
What approach did you choose and why?
Bump stringio to the latest release.
Checklist