Register GCS remote logging scheme via provider dispatch (gs://) - #1
Open
guruprasad-boop wants to merge 4 commits into
Open
Register GCS remote logging scheme via provider dispatch (gs://)#1guruprasad-boop wants to merge 4 commits into
guruprasad-boop wants to merge 4 commits into
Conversation
Airflow resolves remote task log handlers through provider dispatch on the remote_base_log_folder URL scheme since apache#67056; providers must expose from_config so core and the Task SDK no longer depend on the hardcoded branches in airflow_local_settings.py. This migrates the gs scheme, following the s3 and cloudwatch migrations. part of apache#70266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements apache#70266
Adds GCSRemoteLogIO.from_config() and registers the gs scheme so remote_base_log_folder =
gs://... goes through provider dispatch instead of the old airflow_local_settings.py branch.
Followed the S3/CloudWatch pattern from apache#69817/apache#69816 and the factory contract from apache#67056 —
kept the legacy gs:// branch as a fallback and left Stackdriver alone since that's a separate
migration.
what changed:
testing:
ran the full google provider suite through breeze, 4920 passed / 0 failed. new tests pass on
their own too. checked the from_config output matches the S3 reference almost line for line
(only real diff is the gcp_key_path bit, which is GCS-specific).
didn't do a live e2e run against real GCS since I don't have an account for it — everything
here is unit-tested with mocks. also didn't touch stackdriver, same provider but out of scope
for this.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code