Skip to content

Enhance layout change handling - #49

Merged
Signynt merged 1 commit into
Signynt:mainfrom
Moyf:main
Jan 25, 2026
Merged

Enhance layout change handling#49
Signynt merged 1 commit into
Signynt:mainfrom
Moyf:main

Conversation

@Moyf

@Moyf Moyf commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Resolve #21

Hey! I tried to locate the issue, and found out that it's due to layout-change, so I add a new condition to decide whether refresh based on "if file change".

Now it works fine with my Hover Editor, could you check it when you have time?

@Signynt

Signynt commented Jan 25, 2026

Copy link
Copy Markdown
Owner

Sorry, accidentally merged this, reverted it back again.
I have some bugs when using this PR, specifically when opening new files and switching between reading and editing view. The virtual content then get's inserted in the wrong places (editing view), or not at all (reading view).

  1. How it's supposed to look, and looks when I initially open the file (so in this case it works correctly:
image
  1. When I then toggle to "Reading View":
image
  1. When I then toggle back to "Editing View":
image

@Moyf

Moyf commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, accidentally merged this, reverted it back again. I have some bugs when using this PR, specifically when opening new files and switching between reading and editing view. The virtual content then get's inserted in the wrong places (editing view), or not at all (reading view).

  1. How it's supposed to look, and looks when I initially open the file (so in this case it works correctly:
image 2. When I then toggle to "Reading View": image 3. When I then toggle back to "Editing View": image

Ah, I see... it seems I need to also consider the view modes.
I'll continue digging into it, thank you for your test! 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feedback] Conflict with Hover Editor Plugin

2 participants