Evict lingering sessions when enabling read_committed_snapshot on tem…#957
Merged
SimonCropp merged 1 commit intoMay 24, 2026
Conversation
…plate Evict lingering sessions when enabling read_committed_snapshot on template read_committed_snapshot requires exclusive access to the database. The ALTER added in #932 had no termination clause, so it waited for any session a buildTemplate/callback left open instead of evicting it, blocking until the command timeout (Execution Timeout Expired). This surfaced in consumers whose callback builds schema via an SMO ServerConnection, which holds a connection to the template open persistently. LocalDb's own EF callbacks close their connections, so CI stayed green. Add "with rollback immediate" so the statement evicts other sessions, consistent with the surrounding single_user/detach commands. Add regression test BuildTemplateLeavesConnectionOpen: without the fix the rebuild hangs ~35s then fails; with it, passes in ~10s.
SimonCropp
deleted the
Evict-lingering-sessions-when-enabling-read_committed_snapshot-on-template
branch
github-actions
Bot
restored the
Evict-lingering-sessions-when-enabling-read_committed_snapshot-on-template
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…plate
Evict lingering sessions when enabling read_committed_snapshot on template read_committed_snapshot requires exclusive access to the database. The ALTER added in #932 had no termination clause, so it waited for any session a buildTemplate/callback left open instead of evicting it, blocking until the command timeout (Execution Timeout Expired). This surfaced in consumers whose callback builds schema via an SMO ServerConnection, which holds a connection to the template open persistently. LocalDb's own EF callbacks close their connections, so CI stayed green.
Add "with rollback immediate" so the statement evicts other sessions, consistent with the surrounding single_user/detach commands. Add regression test BuildTemplateLeavesConnectionOpen: without the fix the rebuild hangs ~35s then fails; with it, passes in ~10s.