Add Delete Action No Reply Notification message - #668
Merged
Conversation
AAlier
changed the title
tibbi
reviewed
Jun 24, 2023
tibbi
reviewed
Jun 26, 2023
| <string name="mark_as_read">Mark as Read</string> | ||
| <string name="mark_as_unread">Mark as Unread</string> | ||
| <string name="me">Me</string> | ||
| <string name="delete">Delete</string> |
Contributor
There was a problem hiding this comment.
no need to add this string at all, it comes from Simple Commons. Just try referencing it in the code and you will see that it works.
Contributor
Author
There was a problem hiding this comment.
Nice catch. Didn`t know, fixed it
Contributor
|
looks good, thanks. But write things like "fix #89" into the PRs text somewhere. It is a keyword and it will automatically close the issue after accepting the pull request. |
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Delete option to any no reply SMS message
Screenshot