Avoid using vmap when parallel_chunk_size=1#221
Closed
ValerianRey wants to merge 8 commits intomainfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
54cbfa8 to
177349e
Compare
10125d6 to
a3e73cc
Compare
4c279aa to
d699f6d
Compare
d699f6d to
5acde22
Compare
vmap when parallel_chunk_size=1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallel_chunk_size=1+ comment to explain that this is a fix to vmapJacwithchunk_size=1.backwardandmtl_backwardwithparallel_chunk_size=1.Note that even without the change to
Jac, and even with CUDA,test_tensor_used_multiple_timessucceeds, so the issue is really with CUDA + RNN rather than with CUDA + the graph of tensors being cyclical. Still, I think this test is interesting so I kept it.