Extract DiRegistrationMap for explicit container registrations (#233)#239
Merged
Conversation
Move MSDI Add*/TryAdd and Autofac RegisterType/Register collection into a shared map so Captive Dependency DP062 constructor analysis reads type→lifetime from Build instead of private analyzer lists. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiRegistrationMap/DiRegistrationMapBuilderthat records type→lifetime from explicit MSDI (Add*/TryAdd) and Autofac (RegisterType/Register) registrations.CaptiveDependencyAnalyzerDP062 constructor analysis for those entries to read the map; keep attributedRegisterDiand DP066 factory-delegate collection private (out of scope for Registration map: explicit container registrations #233).Related Issue
Closes #233
Solution module
DesignPatterns.Analyzers/+DesignPatterns.CodeFixes/)Type of change
Test plan
dotnet test tests/DesignPatterns.Analyzers.Tests --filter FullyQualifiedName~DiRegistrationMapTestsdotnet test tests/DesignPatterns.Analyzers.Tests --filter "FullyQualifiedName~CaptiveDependency|FullyQualifiedName~FactoryDelegateCaptive"./build.ps1 --target Ci --configuration ReleaseBreaking changes
Checklist
Documentation checklist