[BPK-971] Upgrade webpack deps#224
Conversation
Added `--open` flag to automatically open web browser for docs dev.
Matt Davidson-Loubet (matthewdavidson)
force-pushed
the
bpk-971-webpack-deps
branch
from
4612b82 to
a002323
Compare
Generated by 🚫 dangerJS |
| "storybook": "start-storybook -p 9001", | ||
| "sassdoc": "sassdoc {packages/bpk-mixins/src/**/*,packages/bpk-svgs/dist/*,packages/bpk-tokens/tokens/base.default}.scss -d dist/sassdoc -v --strict --debug", | ||
| "docs": "webpack-dev-server", | ||
| "docs": "webpack-dev-server --open", |
There was a problem hiding this comment.
Awesome!! 🎉
|
I've tested storybook dev ( |
Hugo Tunius (k0nserv)
left a comment
Hugo Tunius (k0nserv)
left a comment
There was a problem hiding this comment.
LGTM.
Surprised we didn't have to make any code changes with the Webpack 3 upgrade etc
Matteo Hertel (matteo-hertel)
left a comment
Matteo Hertel (matteo-hertel)
left a comment
There was a problem hiding this comment.
LGTM
| /******/ | ||
| /******/ // Load entry module and return exports | ||
| /******/ return __webpack_require__(__webpack_require__.s = 1); | ||
| /******/ return __webpack_require__(__webpack_require__.s = 0); |
There was a problem hiding this comment.
I couldn't find in the links you posted where this change comes from - what does it do?
There was a problem hiding this comment.
extract-text-webpack-plugin added sorting https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/CHANGELOG.md#300-rc1-2017-07-07
|
Hugo Tunius (@k0nserv) me too - for comparison, here is CRA's webpack 3 upgrade PR react/create-react-app#2574 |
Matt Davidson-Loubet (matthewdavidson)
deleted the
bpk-971-webpack-deps
branch
5 participants
This is one of the many PR's aimed at upgrading dependencies in the backpack monorepo. I focus on updating webpack based dependencies. Here are the list of changelogs:
Also added
--openflag to automatically open web browser for docs dev.