first revision by SloNN · Pull Request #4 · SloNN/test

SloNN · 2017-03-30T13:23:43Z

No description provided.

SloNN · 2017-03-30T13:24:17Z

please remove empty lines

SloNN · 2017-03-30T13:25:28Z

 {
-	int a = 1
-
+	int a = 1;


please give good name for a

SloNN · 2017-03-30T13:29:07Z

@@ -0,0 +1,4 @@
+int do_smth()
+{
+


no return value

SloNN · 2017-03-30T13:34:29Z

 int do_smth()
 {
-
+	return 0;


please return 1

SloNN · 2017-03-30T13:34:50Z

 int main()
 {
 	int some_variable = 1;  
+	int new_variable = 0;


please add new variable

SloNN

general review

SloNN · 2017-03-31T08:53:57Z

@@ -1,4 +1,4 @@
 int do_smth()


change to void

third comment

SloNN · 2017-03-31T09:48:21Z

@@ -1,4 +1,5 @@
 int main()
 {
-	int a = 1;


empty comment

empty comment 2

empty comment review 3

SloNN · 2017-03-31T09:48:35Z

@@ -1,4 +1,5 @@
 int main()


comment after ok

SloNN · 2017-04-02T13:51:51Z

Comment for the whole commit

SloNN · 2017-04-02T13:52:08Z

One more comment

SloNN · 2017-04-03T09:55:29Z

@@ -1,5 +1,4 @@
 int main()


SloNN · 2017-04-03T09:55:38Z

@@ -1,5 +1,4 @@
 int main()


SloNN · 2017-04-04T08:09:42Z

@@ -1,4 +1,5 @@
 int main()


новый conversation

SloNN · 2017-04-07T12:45:51Z

@@ -1,4 +1,4 @@
 int do_smth()


SloNN · 2017-04-19T14:47:50Z

@@ -1,4 +1,5 @@
 int main()


comment after ok

SloNN · 2017-04-19T15:09:06Z

 int do_smth()
 {
-
+	return 0;


new conversation

SloNN · 2017-04-19T15:10:47Z

@@ -1,4 +1,4 @@
 int do_smth()


SloNN

ll

SloNN · 2017-04-19T15:18:26Z

@@ -1,4 +1,5 @@
 int main()


SloNN

mm

SloNN · 2017-04-19T15:22:33Z

@@ -1,4 +1,4 @@
 int do_smth()


first revision

cf58268

removed empty lines

7789b09

SloNN commented Mar 30, 2017

View reviewed changes

Comment thread main.cpp Outdated

{

int a = 1

int a = 1;

SloNN Mar 30, 2017

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please give good name for a

I am added 3 commits March 30, 2017 16:26

removed empty lines

57c3dd2

removed empty lines and renamed variable

4375132

added new file

51acb62

SloNN commented Mar 30, 2017

View reviewed changes

Comment thread do_smth.cpp Outdated

@@ -0,0 +1,4 @@

int do_smth()

{

SloNN Mar 30, 2017

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no return value

returned values

a7c85e8

SloNN commented Mar 30, 2017

View reviewed changes

Comment thread main.cpp

int main()

{

int some_variable = 1;

int new_variable = 0;

SloNN Mar 30, 2017

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add new variable

SloNN commented Mar 31, 2017

View reviewed changes

SloNN commented Apr 19, 2017

View reviewed changes

Comment thread main.cpp

@@ -1,4 +1,5 @@

int main()

SloNN Apr 19, 2017

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bbb

SloNN commented Apr 19, 2017

View reviewed changes

Comment thread do_smth.cpp

@@ -1,4 +1,4 @@

int do_smth()

SloNN Apr 19, 2017

Copy link
Copy Markdown

Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 comment

Conversation

SloNN commented Mar 30, 2017

Uh oh!

SloNN commented Mar 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SloNN left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SloNN commented Apr 2, 2017

Uh oh!

SloNN commented Apr 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!