Don't translate built in style strings (WP-911)#550
Don't translate built in style strings (WP-911)#550vsolovei-smartling merged 5 commits intomasterfrom
Conversation
| <!-- /wp:html --> | ||
|
|
||
| <!-- wp:paragraph {"fontSize":"large","smartlingLockId":"rootlocked","smartlingLockedAttributes":"fontSize"} --> | ||
| <!-- wp:paragraph {"fontsize":"large","smartlingLockId":"rootlocked","smartlingLockedAttributes":"fontSize"} --> |
There was a problem hiding this comment.
We only do not translate style, but fontsize we do, right? Do we have tests for style strings translation like these ones with fontsize?
There was a problem hiding this comment.
fontSize is a built-in property, as is style, they should be copied. I had to rename the test property to fontsize, because it tests locking to ensure only locked properties get copied, other properties should translate
There was a problem hiding this comment.
No tests currently test for style property
There was a problem hiding this comment.
No tests currently test for
styleproperty
ok, I thought this PR for style attribute.
But I saw test where fontsize still has pseudo translation. Is this expected in test? sounds like it should not happen
There was a problem hiding this comment.
The filters are case sensitive, fontSize should now get copied, fontsize is translated. In this test, on lines 64-77 we update the attribute and add locking, changing the original translation to a user-modified string. The expected result for the test is that on next download, the replaced strings without locking to revert to pseudo-translation, and the locked ones should stay as the user has left them
vsolovei-smartling
force-pushed
the
WP-911-3
branch
from
7ccac25 to
fe08e9e
Compare
vsolovei-smartling
force-pushed
the
WP-911-3
branch
from
fe08e9e to
1fb7326
Compare
3 participants
No description provided.