🦋 New version release - #315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/smooth-operator@1.36.4
Patch Changes
b1a0568: SECURITY (.NET server): scope the conversation WRITE path, not just the reads.
th-966fab owner-checked
get_session/get_conversation_messages/ resume, butsend_messagestill loaded any session by client-suppliedsessionId. Anauthenticated user who knew (or guessed) another user's
sessionIdcould send amessage into that session — the turn replayed the victim's conversation history as
context and streamed the agent's reply back to the attacker. A read of someone
else's conversation dressed up as a write, defeating the read scoping entirely.
verify_otpandconfirm_tool_actionwere unscoped the same way (marking aforeign session identity-verified; approving a foreign parked write).
The fix adopts the Go server's chokepoint pattern: a single private
ScopedSessionAsyncis now the only way a handler may turn a client-suppliedsessionIdinto a session. It hides a session the connection's principal doesn'town by returning exactly what an unknown id returns, so every caller emits the
identical not-found response and "not yours" stays indistinguishable from "never
existed". All five sessionId-taking handlers route through it.
The visibility rule is "Option B": a session that HAS an owner is owner-checked; a
session with NO owner is reachable. A first attempt (SECURITY: scope the .NET conversation write path (send_message et al) via a session chokepoint #308) also denied ownerless
sessions and emailless principals outright, and was reverted (Revert: .NET write-path scoping (#308) — hangs CI, denies anonymous/emailless principals #309) — an
authenticated principal whose token carries no
emailclaim, and an anonymousconnection to an auth-enabled server, both stamp
ownerEmail = nullatcreate_conversation_sessionand were then refused by their own session on the nextsend_message. That is not "denied someone else's history", it is "cannot use theproduct": it killed anonymous/public-agent chat, and hung the .NET integration suite,
whose ACL test converses over exactly that path. Ownerless sessions remain absent from
list_conversationsand non-resumable byconversationId, so reaching one requiresalready holding its
sessionId. No behavior change when auth is disabled(single-tenant local/dev stays unscoped).
@smooai/smooth-operator-web-chat-example@0.0.40
Patch Changes