π¦ New version release - #316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/smooth-operator@1.36.5
Patch Changes
5d0a499: SECURITY (Python server): scope sessions by owner only when an owner exists (Option B, th-909995)
The th-8fe998 scoping rule fail-closed on any principal without an email claim. On an
auth-enabled server that locked out anonymous connections and authenticated-but-emailless
principals entirely β the session they had just created was ownerless, so
list_conversationsreturned empty, resume minted a fresh conversation, and
get_session/get_conversation_messages/
send_messageall answeredSESSION_NOT_FOUND. The identical rule in the .NET twin hung CI ona WebSocket ACL test and was reverted in Revert: .NET write-path scoping (#308) β hangs CI, denies anonymous/emailless principalsΒ #309.
Option B: a session that HAS an owner is still owner-checked (case/whitespace-insensitive email
match); a session with NO owner β anonymous, emailless, or predating ownership β is reachable, as
it was before scoping shipped. An emailless scope matches no non-empty owner, so the reported P0
stays closed: authenticated A cannot read, resume, or
send_messageinto authenticated B's ownedsession, and a refusal appends nothing to B's log. Not-yours remains byte-identical to
never-existed (no existence oracle), and the auth-disabled single-tenant flavor is unchanged.
Option A (
email ?? sub) was rejected: Go's anonymous principal uses the literal sub"anonymous"for every visitor, so keying on
subwould pool all anonymous visitors together and leak theirchats to each other.
SessionStore.create_session/list_conversationsgain a keyword-onlyenforced: bool = Falsethat distinguishes "auth disabled, unscoped" from "authenticated but emailless" β both of which
present as a
Noneowner.@smooai/smooth-operator-web-chat-example@0.0.41
Patch Changes