π¦ New version release - #317
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/smooth-operator@1.36.6
Patch Changes
86465a1: SECURITY (Go): fix conversation ownership check to close cross-user access without locking out anonymous and emailless principals.
The previous rule (
s.Unscoped || (s.Email != "" && ownerEmail == s.Email)) denied everything to any connection whose principal carried no email claim. On an auth-enabled server that population is real βAnonymousPrincipalhas no email, and plenty of IdPs issue tokens without one β so those callers got an empty conversation list, a refused resume, and a refusedsend_messageon the session they had just created. That is an outage for anonymous/public-agent chat, a supported scenario. The identical rule in the .NET sibling hung CI on a WebSocket ACL test that authenticates without an email claim, forcing a revert there (Revert: .NET write-path scoping (#308) β hangs CI, denies anonymous/emailless principalsΒ #309); Go had no equivalent test, which is why it went unnoticed.ConversationScope.Allowsnow owner-checks only conversations that HAVE an owner:Keying ownerless sessions on
subinstead was considered and rejected:AnonymousPrincipal.Subis the literal string"anonymous"for every visitor, so it would pool all anonymous conversations into one shared bucket and leak them to each other.Email comparison is now case-insensitive (
strings.EqualFold), matching the .NET and Python siblings β OIDC providers vary on the casing of the email claim.Unchanged: the
scopedSessionchokepoint every sessionId-taking handler routes through, the identicalSESSION_NOT_FOUNDfor not-yours vs never-existed (no existence oracle), selection-side filtering for the conversation list, and the auth-disabled unscoped path.@smooai/smooth-operator-web-chat-example@0.0.42
Patch Changes