π¦ New version release - #319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/smooth-operator@1.36.7
Patch Changes
799124c: SECURITY (Rust server): scope conversations by owner only when an owner exists (Option B, th-909995)
may_read_conversationmapped every principal without an email β an anonymous connection to anauth-enabled server, or a token carrying
sub/org/rolebut noemailβ toUserScope::Deniedand refused it everything. The session such a connection creates is ownerless by construction, so
it was locked out of its own session: empty
list_conversations, resume refused,get_session/get_conversation_messages/send_messageallSESSION_NOT_FOUND. The identical rule in the.NET twin hung CI on a WebSocket ACL test and was reverted in Revert: .NET write-path scoping (#308) β hangs CI, denies anonymous/emailless principalsΒ #309.
Option B: a conversation that HAS an owner (a
userparticipant with a non-blank email) is stillowner-checked, case-insensitively; one with NO owner is readable, as it was before scoping shipped.
Deniedmatches no non-empty owner, so the reported P0 stays closed: authenticated A cannot read,resume, or
send_messageinto authenticated B's owned session, and a refusal appends nothing toB's log.
Err(_) => false(a storage error is a denial), theUserScopeenum, and thescoped_sessionchokepoint at all 7 call sites are unchanged, as is the unauthenticatedLocalServer/ smooth-daemon embedding (UserScope::Unscoped).Option A (
email ?? sub) was rejected: Go's anonymous principal uses the literal sub"anonymous"for every visitor, so keying on
subwould pool all anonymous visitors and leak their chats toeach other.
list_conversationsnow applies that same predicate per conversation instead of thelist_conversations_by_org_and_userstorage pushdown, which cannot express "mine or ownerless" βso the list can never disagree with what
get_sessionwill hand over. Still filtered before thelimit, so pages are never silently short.
@smooai/smooth-operator-web-chat-example@0.0.43
Patch Changes