test(parity): unsupported-action scenario + fix the real Go divergence it caught - #71
Merged
Conversation
…rgence it caught New scenario: an unrecognized action must return error/UNSUPPORTED_ACTION with the requestId echoed. It caught a REAL Go-server bug that #65 had masked with a knownGoDivergence SKIP: Go errorEvent() emitted the {code,message} descriptor only under data.error, never at the envelope level error — and used NOT_FOUND instead of canonical SESSION_NOT_FOUND. Both diverge from spec/events/error.schema.json + the Python/Rust/C#/TS servers. Fix (root cause): protocol.go errorEvent now sets the envelope-level error descriptor (kept data.error for back-compat); dispatcher.go uses SESSION_NOT_FOUND; updated the existing TestUnknownSessionErrors to the canonical code; removed the knownGoDivergence skip. Go now passes ALL scenarios (incl. the previously-skipped unknown-session-error) — full suite green -race. All 5 servers green on the new scenario. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7Mn93HpqhSgEmX6tRdPAv
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the unsupported-action-error scenario to the shared corpus — and it immediately caught a real Go-server divergence that #65 had masked with a hidden skip (
knownGoDivergence).The bug (Go server)
protocol.go errorEvent()emitted the{code,message}descriptor only underdata.error, never at the envelope-levelerror— and usedNOT_FOUNDinstead of canonicalSESSION_NOT_FOUND. Both diverge fromspec/events/error.schema.jsonand the Python/Rust/C#/TS servers (the same bug class fixed for TS in #63 and C# in #64). Theparity-goport (#65) had documented this and skippedunknown-session-errorrather than fixing the server — so Go was never truly at parity.The fix
protocol.go errorEvent→ sets the envelope-levelerrordescriptor (keepsdata.errorfor back-compat).dispatcher.go→SESSION_NOT_FOUND.TestUnknownSessionErrorsto the canonical code.knownGoDivergenceskip → Go now runs + passesunknown-session-errortoo.Go full suite green
-race; all five servers green on the new scenario. True parity restored.🤖 Generated with Claude Code