fix(release): sync-versions skips external git deps (unblocks v0.23.0)#260
Merged
Conversation
…r-core The version-injection guard matched only smooai-smooth-operator-core, so the operator git deps (smooth-operator-server/-svc) still got version = <workspace> stamped each release. At rev 9db9d319 those crates are 1.23.1, not 0.23.0, so cargo could not resolve and the Changesets version PR (#222) Rust checks failed — blocking the v0.23.0 release (which carries the th testing coverage CLI). Both passes now skip any workspace.dependencies entry with a git = key. Verified: operator git deps stay version-less, internal path deps still sync. Pearl th-1ee32b. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KTQCKSkMFSE1j6QwD29BGL
🦋 Changeset detectedLatest commit: 14aadb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brentrager
enabled auto-merge (squash)
July 25, 2026 16:43
brentrager
added a commit
that referenced
this pull request
Jul 25, 2026
…too (#262) #260 stopped stamping the operator git deps in Cargo.toml, but the Cargo.lock pass still bumped smooai-smooth-operator-server/-svc lock entries to the workspace version (0.23.0). Their git source at rev 9db9d319 is 1.23.1, so cargo --locked failed to resolve — the version PR (#222) stayed red on a different line. Skip all three external operator package names by exact match in the lock pass, mirroring the Cargo.toml git-dep skip. Pearl th-1ee32b. Claude-Session: https://claude.ai/code/session_01KTQCKSkMFSE1j6QwD29BGL Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Changesets version PR (#222, ships v0.23.0 — the release carrying the
th testing coverageCLI) has been red for 10 days on Rust checks:No release has shipped since, so the coverage-measurement dogfood (
report-coverage.shin smooai CI) silently no-ops — it feature-detectsth testing coverageand that subcommand isn't in any publishedth.Root cause
sync-versions.mjsinjectsversion = "<workspace>"ontoworkspace.dependenciesentries. It skippedsmooai-smooth-operator-core(crates.io dep) but not the operator git depssmooth-operator-server/smooth-operator-svc. Those are pinned by rev; the crate version there is1.23.1, unrelated to the workspace0.23.0— so^0.23.0can't resolve. The earlier core-only guard (and PR #199) don't cover them because their package names aren't-core.Fix
Both version passes now skip any entry with a
git =key (git deps carry their version at the pinned rev, not the workspace version), keeping the existing crates.io-core name-guard.Verified against the real
Cargo.toml: operator git deps stay version-less; internal path deps (e.g.smooth-policy) still sync. Authoritative test is #222's Rust check re-running green after the version PR regenerates.Supersedes #199 (narrower core-only fix). Pearl th-1ee32b.
🤖 Generated with Claude Code