Skip to content

Update ABLP Loader in preparation for graph store - #478

Merged
kmontemayor2-sc merged 9 commits into
mainfrom
kmonte/setup-ablp-loader-for-gs
Feb 11, 2026
Merged

Update ABLP Loader in preparation for graph store#478
kmontemayor2-sc merged 9 commits into
mainfrom
kmonte/setup-ablp-loader-for-gs

Conversation

@kmontemayor2-sc

@kmontemayor2-sc kmontemayor2-sc commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Scope of work done

Breaking out the changes to support colocated in graph store mode to their own PR (this one) so it's easier to review. In hindsight, #432 was probably too complicated and the ABLP changes will be even more so.

See #475 for the MVP here.

This PR should be a no-op (other than fixing some typos in logs).

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/unit_test_py

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/integration_test

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 24:33:55UTC : 🔄 Integration Test started.

@ 01:56:33UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 24:33:57UTC : 🔄 Python Unit Test started.

@ 01:52:54UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 24:34:02UTC : 🔄 E2E Test started.

@ 02:06:03UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/unit_test_py

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/integration_test

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 17:43:26UTC : 🔄 Integration Test started.

@ 19:02:17UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 17:43:26UTC : 🔄 Python Unit Test started.

@ 18:56:46UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc

kmontemayor2-sc commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

/e2e_test

@github-actions

github-actions Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 17:45:54UTC : 🔄 E2E Test started.

@ 19:01:14UTC : ✅ Workflow completed successfully.

mkolodner-sc
mkolodner-sc reviewed Feb 6, 2026
View reviewed changes

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! Left a few comments.

Comment thread gigl/distributed/dist_ablp_neighborloader.py Outdated
Comment thread gigl/distributed/dist_ablp_neighborloader.py Outdated
Comment thread gigl/distributed/dist_ablp_neighborloader.py
kmontemayor2-sc
kmontemayor2-sc commented Feb 10, 2026
View reviewed changes
Comment thread gigl/distributed/dist_ablp_neighborloader.py
Comment thread gigl/distributed/dist_ablp_neighborloader.py Outdated
Comment thread gigl/distributed/dist_ablp_neighborloader.py Outdated
Comment thread gigl/distributed/dist_ablp_neighborloader.py
mkolodner-sc
mkolodner-sc approved these changes Feb 10, 2026
View reviewed changes

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! LGTM provided one comment is addressed.

Comment thread gigl/distributed/distributed_neighborloader.py Outdated
@kmontemayor2-sc

kmontemayor2-sc commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator Author

FYI @mkolodner-sc renamed to is_homogeneous_with_labeled_edge_type per our offline discussions.

@kmontemayor2-sc
kmontemayor2-sc marked this pull request as ready for review February 11, 2026 00:35
@kmontemayor2-sc
kmontemayor2-sc added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit fc55f1d Feb 11, 2026
6 checks passed
@kmontemayor2-sc
kmontemayor2-sc deleted the kmonte/setup-ablp-loader-for-gs branch February 11, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliu2-sc yliu2-sc yliu2-sc approved these changes
@mkolodner-sc mkolodner-sc mkolodner-sc approved these changes
@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner
@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner
@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner
@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmontemayor2-sc @yliu2-sc @mkolodner-sc @kmonte