Skip to content

Feature Quantization [3/5]: Preprocessor (write-side) Updates - #735

Merged
jchmura-sc merged 34 commits into
mainfrom
jchmura/feature_quant_preprocessor
Aug 11, 2026
Merged

Feature Quantization [3/5]: Preprocessor (write-side) Updates#735
jchmura-sc merged 34 commits into
mainfrom
jchmura/feature_quant_preprocessor

Conversation

@jchmura-sc

@jchmura-sc jchmura-sc commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Purpose
The purpose of this PR is to make the (write-side) preprocessor changes for feature quantization:

  • FeatureQuantizationSpec the API endpoint that the user can specific inside NodeDataPreprocessingSpec
  • beam transform for computing quantization metadata and serializing to temporary json
  • beam transform for quantizing node features based on that metadata (calls into quantize_ndarray)
  • driver reads the json, constructs FeatureQuantizationMetadata proto, and adds to preprocessed_metadata_pb

Context

Updated Changelog.md? NO

Ready for code review?: NO

Comment thread gigl/src/data_preprocessor/lib/transform/feature_quantization.py Outdated
@jchmura-sc
jchmura-sc marked this pull request as ready for review August 7, 2026 19:17
@jchmura-sc
jchmura-sc requested a review from svij-sc as a code owner August 7, 2026 19:17
Base automatically changed from jchmura/feature_quant_ops to main August 9, 2026 01:35

@kmontemayor2-sc kmontemayor2-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Jacob!

Comment thread proto/snapchat/research/gbml/preprocessed_metadata.proto

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jacob!

Comment thread gigl/common/utils/feature_quantization/__init__.py Outdated
Comment thread gigl/src/data_preprocessor/lib/transform/feature_quantization.py Outdated
Comment thread gigl/src/data_preprocessor/lib/types.py

@yliu2-sc yliu2-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 10, 2026
@jchmura-sc
jchmura-sc enabled auto-merge August 10, 2026 21:26
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 10, 2026
Comment thread gigl/src/data_preprocessor/data_preprocessor.py Outdated
@jchmura-sc
jchmura-sc removed this pull request from the merge queue due to a manual request Aug 10, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 10, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit 9aaa791 Aug 11, 2026
7 checks passed
@jchmura-sc
jchmura-sc deleted the jchmura/feature_quant_preprocessor branch August 11, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants