Preserve fetched original edges for hetero PPR - #743
Open
mkolodner-sc wants to merge 28 commits into
Open
Conversation
…erve-original-edges # Conflicts: # gigl-core/core/sampling/ppr_forward_push.h # gigl/distributed/dist_ppr_sampler.py
kmontemayor2-sc
approved these changes
Aug 11, 2026
yliu2-sc
approved these changes
Aug 11, 2026
mkolodner-sc
marked this pull request as ready for review
August 12, 2026 18:30
mkolodner-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
August 12, 2026 18:30
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds opt-in preservation of original graph edges for heterogeneous PPR sampling.
When
include_original_edges_in_ppr_subgraph=True, the PPR sampler now emits original graph edges whose endpoints are already present in the PPR-selected node set and whose adjacency rows were fetched during PPR traversal. The default remainsFalse, which is the more faithful behavior relative to PyG’sget_pprAPI: output only virtual seed-to-PPR-node edges.Changes
PPRForwardPushcache with optional edge IDs._sample_one_hoppassrun_in_executorDatasupport explicitly unsupported for this flag.Output Behavior
For heterogeneous PPR:
("seed_type", "ppr", "neighbor_type").edge_dirorientation convention as k-hop sampling.Validation
make -C gigl-core unit_test_cpptest_typed_ppr_sampler_loader_outputs_channel_attrstest_ppr_sampler_can_preserve_original_edges_for_selected_nodesgit diff --checkmake -C gigl-core check_format_cppruff checkon touched Python/stub filesLocal Benchmark
Synthetic no-edge-feature dataloader benchmark, flag off vs on:
Average across these cases: approximately
+1.33 ms/batchmean overhead. While nonzero, this slowdown is relatively negligible.