Skip to content

Jchmura/edge feature quantization - #745

Draft
jchmura-sc wants to merge 83 commits into
mainfrom
jchmura/edge-feature-quantization
Draft

Jchmura/edge feature quantization#745
jchmura-sc wants to merge 83 commits into
mainfrom
jchmura/edge-feature-quantization

Conversation

@jchmura-sc

Copy link
Copy Markdown
Collaborator

Scope of work done

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@jchmura-sc jchmura-sc self-assigned this Aug 12, 2026
Comment thread gigl/distributed/dist_dataset.py
Comment thread gigl/src/data_preprocessor/lib/transform/utils.py Outdated
Comment thread gigl/distributed/base_sampler.py Outdated
Comment thread gigl/distributed/dist_range_partitioner.py
Comment thread gigl/src/data_preprocessor/lib/transform/feature_quantization.py Outdated
Comment thread gigl/src/data_preprocessor/lib/transform/feature_quantization.py Outdated
Comment on lines +166 to +169
if packed_feature_key in batch.schema.names:
raise ValueError(
f"Reserved packed feature key {packed_feature_key} already exists in the logical schema."
)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This or the check at the beggining of the quantization can be removed, as they check the same thing

Comment thread gigl/src/data_preprocessor/lib/transform/feature_quantization.py
Comment thread gigl/distributed/utils/neighborloader.py
Comment thread gigl/distributed/utils/neighborloader.py Outdated
Comment thread gigl/common/data/load_torch_tensors.py
Base automatically changed from jchmura/feature_quant_integration to main August 13, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant