Jchmura/edge feature quantization - #745
Draft
jchmura-sc wants to merge 83 commits into
Draft
Conversation
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
Comment on lines
+166
to
+169
| if packed_feature_key in batch.schema.names: | ||
| raise ValueError( | ||
| f"Reserved packed feature key {packed_feature_key} already exists in the logical schema." | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
This or the check at the beggining of the quantization can be removed, as they check the same thing
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
jchmura-sc
commented
Aug 13, 2026
…ature-quantization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO