🌱 Removing the temporary shouldDelete option to kubeClient.Apply that was not used anyway and always set on true - #233
Merged
Conversation
aniruddha2000
force-pushed
the
ani/issues/232
branch
from
June 27, 2024 10:45
eb7ac3e to
a61e5a3
Compare
janiskemper
requested changes
Jun 27, 2024
janiskemper
left a comment
janiskemper
left a comment
Member
There was a problem hiding this comment.
you left some "Apply" calls with 4 or even 5 parameters, but the interface says it's only 3
Removing the shouldDelete option in kubeClient.Apply that was not used anyway and always set on true. Co-authored-by: janiskemper <63146658+janiskemper@users.noreply.github.com> Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
aniruddha2000
force-pushed
the
ani/issues/232
branch
from
June 28, 2024 10:39
638dcb1 to
594c5e8
Compare
janiskemper
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #232
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: