This repository was archived by the owner on Dec 16, 2025. It is now read-only.
⚠️ Add default values for the 'cloudName' and 'identityRef' fields#101
Merged
Conversation
michal-gubricky
marked this pull request as ready for review
February 20, 2024 12:02
michal-gubricky
changed the title
janiskemper
reviewed
Feb 20, 2024
michal-gubricky
force-pushed
the
feat/add-default-values
branch
2 times, most recently
from
February 21, 2024 14:18
397ec1d to
71f6031
Compare
matofeder
reviewed
Feb 23, 2024
michal-gubricky
force-pushed
the
feat/add-default-values
branch
from
February 23, 2024 13:37
71f6031 to
0dda9ac
Compare
michal-gubricky
force-pushed
the
feat/add-default-values
branch
from
February 26, 2024 11:53
bf15a81 to
13e4795
Compare
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
…se resource Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/add-default-values
branch
from
February 26, 2024 11:58
13e4795 to
937bb0f
Compare
matofeder
reviewed
Feb 27, 2024
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add default values for the 'cloudName' and 'identityRef' fields and move
cloudNameto the secret.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #90
TODOs: