This repository was archived by the owner on Dec 16, 2025. It is now read-only.
🌱 Remove unnecessary env variables in make target env-vars-for-wl-cluster#102
Merged
Conversation
michal-gubricky
force-pushed
the
feat/env-variables
branch
from
February 22, 2024 08:49
07970d3 to
2951b16
Compare
michal-gubricky
marked this pull request as ready for review
February 22, 2024 08:49
matofeder
reviewed
Feb 23, 2024
michal-gubricky
force-pushed
the
feat/env-variables
branch
from
February 23, 2024 13:08
f83b864 to
da8fda0
Compare
matofeder
reviewed
Feb 23, 2024
michal-gubricky
force-pushed
the
feat/env-variables
branch
from
February 23, 2024 13:17
da8fda0 to
7524e4e
Compare
Based on the introduction of local_mode feature(see issue #76). Some env variables are not needed when we are using local_mode. This commit adjust .envrc.sample and also remove these unnecessary env variables in make target env-vars-for-wl-cluster. Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/env-variables
branch
from
February 23, 2024 13:21
7524e4e to
0189b43
Compare
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/env-variables
branch
from
February 23, 2024 14:10
0189b43 to
dc7f129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on the introduction of
local_modefeature(see issue #76). Some env variables are not needed when we are using local_mode. This commit adjust .envrc.sample and also remove these unnecessary env variables in make target env-vars-for-wl-cluster.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #100
TODOs: