This repository was archived by the owner on Dec 16, 2025. It is now read-only.
🌱 Add fake github client#113
Merged
Merged
Conversation
michal-gubricky
marked this pull request as ready for review
February 28, 2024 15:11
janiskemper
reviewed
Feb 28, 2024
janiskemper
left a comment
janiskemper
left a comment
Member
There was a problem hiding this comment.
The Go code looks good to me. I don't wanna review the config folder though ;)
michal-gubricky
force-pushed
the
feat/add-fake-github-client
branch
from
February 28, 2024 15:25
dc332ea to
53d697c
Compare
kranurag7
reviewed
Feb 28, 2024
michal-gubricky
force-pushed
the
feat/add-fake-github-client
branch
from
February 29, 2024 14:21
6938b39 to
ea17153
Compare
matofeder
approved these changes
Feb 29, 2024
kranurag7
approved these changes
Feb 29, 2024
kranurag7
left a comment
kranurag7
left a comment
Contributor
There was a problem hiding this comment.
I rebased this branch against main and tested it again locally.
LGTM.
Thank you @michal-gubricky
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/add-fake-github-client
branch
from
March 1, 2024 11:48
ea17153 to
4f6eb60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on the discussion in #100 (comment). This PR implements the fake GitHub client, when
local_modeis enabled.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #103
TODOs: