This repository was archived by the owner on Dec 16, 2025. It is now read-only.
⚠️ OpenStack with pascal case#15
Merged
Merged
Conversation
chess-knight
requested review from
janiskemper,
kranurag7,
matofeder and
michal-gubricky
December 19, 2023 08:52
batistein
approved these changes
Dec 19, 2023
kranurag7
suggested changes
Dec 19, 2023
kranurag7
left a comment
kranurag7
left a comment
Contributor
There was a problem hiding this comment.
LGTM @chess-knight Please do a rebase from main branch.
It will be aligned with CAPO Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
chess-knight
force-pushed
the
feat/OpenStackPascalCase
branch
from
December 19, 2023 10:46
be4bea6 to
f4bdf2a
Compare
kranurag7
approved these changes
Dec 19, 2023
kranurag7
left a comment
kranurag7
left a comment
Contributor
There was a problem hiding this comment.
LGTM, given verification of labels are passing.
michal-gubricky
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It will be aligned with CAPO