Skip to content

🌱 feat(scs2): Add image references#245

Merged
jschoone merged 6 commits into
mainfrom
feat/add-image-reference-to-scs2
Feb 12, 2026
Merged

🌱 feat(scs2): Add image references#245
jschoone merged 6 commits into
mainfrom
feat/add-image-reference-to-scs2

Conversation

@jschoone

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
@jschoone jschoone changed the title :seefeat(scs2): Add image references 🌱 feat(scs2): Add image references Dec 17, 2025
@jschoone jschoone self-assigned this Dec 17, 2025
@jschoone jschoone mentioned this pull request Dec 17, 2025
1 task
@garloff

garloff commented Dec 17, 2025

Copy link
Copy Markdown
Member

I like it!
Does this need testing?

Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
@jschoone

Copy link
Copy Markdown
Contributor Author

I like it! Does this need testing?

Yes, would be great. I had no luck so far. The openstack-image-manager and orc both don't complain about the files and start the import but that never finishes

@jschoone

jschoone commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Ok that ORC image has now been uploaded in my test

@schneidarno

Copy link
Copy Markdown
Contributor

Ok that ORC image has now been uploaded in my test

How did you solve this? In my environment, the upload also get stuck in the "queued" state.

@Nils98Ar

Nils98Ar commented Dec 18, 2025

Copy link
Copy Markdown
Member

It's the same in my environment as it seems. At least yesterday.

@jschoone

Copy link
Copy Markdown
Contributor Author

Just applied the resource as it is. What does a kubectl describe say?

@jschoone

Copy link
Copy Markdown
Contributor Author

In the status is a condition with the progress: kubectl get images -ojsonpath="{ .items[*].status.conditions }" | jq '.[] | select(.type == "Downloading")'
This can take a while because the image is huge. I also face retries, but just left it running and after some time it was uploaded. This probably depends on various components.
I'm currently trying again.

Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
@jschoone

Copy link
Copy Markdown
Contributor Author

Hi @garloff, @schneidarno and @Nils98Ar

Did you have the Chance to test it again?
Is there anything missing?
I'd like to add this image reference before it is too outdated again

openstack-image-manager complains "mages.0.meta.os_purpose: Required field missing"

Signed-off-by: schneidarno <arno.schneider@rz.uni-augsburg.de>
@schneidarno

Copy link
Copy Markdown
Contributor

Hi @garloff, @schneidarno and @Nils98Ar

Did you have the Chance to test it again? Is there anything missing? I'd like to add this image reference before it is too outdated again

I tested it again and fount that the problem was that an image with the same name already existed. Therefore, I received an error stating that the expected size did not match the downloaded size. After deleting the existing image with the same name, it worked for me.

@schneidarno

Copy link
Copy Markdown
Contributor

Hi @garloff, @schneidarno and @Nils98Ar
Did you have the Chance to test it again? Is there anything missing? I'd like to add this image reference before it is too outdated again

I tested it again and fount that the problem was that an image with the same name already existed. Therefore, I received an error stating that the expected size did not match the downloaded size. After deleting the existing image with the same name, it worked for me.

That was a wrong conclusion on my part. The reason was that the image download failed and the image files were truncated.

After a successfull download everything worked as expected.

@jschoone jschoone merged commit 828710f into main Feb 12, 2026
4 checks passed
@jschoone jschoone deleted the feat/add-image-reference-to-scs2 branch February 12, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants