Revert "SCS-0128: Remove testcase that needs instance creation with admin password"#1250
Open
depressiveRobot wants to merge 1 commit into
Open
Revert "SCS-0128: Remove testcase that needs instance creation with admin password"#1250depressiveRobot wants to merge 1 commit into
depressiveRobot wants to merge 1 commit into
Conversation
…dmin pas…" This reverts commit 732cf2b.
Contributor
|
Have you re-created my original PR somewhere? We need to track this somewhere. |
Contributor
|
@toothstone What do you mean by 'recreated the PR'? It was never gone, and it's referenced in this PR's description. |
toothstone
approved these changes
Jul 20, 2026
toothstone
left a comment
toothstone
left a comment
Contributor
There was a problem hiding this comment.
Approving to comply with you wish to discuss this in the SIG, I stand by my assessment that this test case should be dropped ;)
I've opened #1253 to re-apply my original PR in case this one here gets merged. In the future I would appreciate it if that wouldn't fall onto me.
Contributor
|
Out of curiosity, why does this commit not need to be signed-off? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1245
I mistakenly merged this too quickly. Most of the certified providers successfully run this check. This should first be discussed in the SIG Std/Cert.