Skip to content

Enable main check tool to run KaaS tests - #490

Merged
mbuechse merged 3 commits into
mainfrom
issue/485
Feb 29, 2024
Merged

Enable main check tool to run KaaS tests#490
mbuechse merged 3 commits into
mainfrom
issue/485

Conversation

@mbuechse

@mbuechse mbuechse commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

resolves #485

Note: this changes the report format, but the report so far is not being processed automatically
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
resolves #481

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@mbuechse mbuechse changed the title Enable master check tool to run KaaS tests Enable main check tool to run KaaS tests Feb 28, 2024
mbuechse added a commit that referenced this pull request Feb 28, 2024
This won't work without
- #488
- #490

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
@cah-hbaum

Copy link
Copy Markdown
Contributor

I looked a bit around with this topic. IMO there are two options to run kubernetes tests with the pipeline, which do some stuff different:

  1. Use a pre-provided cluster
    If we go this way, I would probably do the testing similar to how it is done already with the clouds.
    We would put the certificate-authority-data, client-certificate-data and client-key-data from the kubeconfig file in use into the secret of the cloud provider and use this in a pre_k8s_cluster.yaml (similar to the existing pre_cloud.yaml) to setup the kubeconfig of each cloud provider. This would also require a kubeconfig jinja file (or similar).

  2. Setup a new cluster each time
    This would be quite elegant, since we could use the cloud instance data already available and create a new cluster to test, BUT it would take quite some time to create such a cluster every time. To create a cluster, we could either use the k8s-cluster-api-provider or ClusterStacks, which would probably both be fine (but ClusterStacks is the way going forward I think).

IMO for now, the quicker, easier solution is option 1. If you want @mbuechse, I can provide a patch or make a commit directly.

@mbuechse

Copy link
Copy Markdown
Contributor Author

@cah-hbaum Yes, we use option one, because (a) we are pressed for time and (b) currently there isn't any universal interface that allows us to create a cluster -- many providers use Gardener, others want to use the Clusterstacks approach from the reference implementation, but that isn't quite done yet.

We have to put the necessary files (client cert etc.) into the secrets part of the Zuul config, but that isn't what this issue is about. This issue pertains only to the Python script.

@cah-hbaum

cah-hbaum commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

@cah-hbaum Yes, we use option one, because (a) we are pressed for time and (b) currently there isn't any universal interface that allows us to create a cluster -- many providers use Gardener, others want to use the Clusterstacks approach from the reference implementation, but that isn't quite done yet.

We have to put the necessary files (client cert etc.) into the secrets part of the Zuul config, but that isn't what this issue is about. This issue pertains only to the Python script.

I will make a commit then. Correction: I will create a patch and send it to Matthias so he can integrate it.

@martinmo martinmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garloff garloff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@mbuechse
mbuechse merged commit fa0de3c into main Feb 29, 2024
@mbuechse
mbuechse deleted the issue/485 branch February 29, 2024 11:31
mbuechse added a commit that referenced this pull request Feb 29, 2024
This won't work without
- #488
- #490

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
mbuechse added a commit that referenced this pull request Mar 6, 2024
This won't work without
- #488
- #490

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Enable main check tool to run KaaS tests

4 participants