Add standard for KaaS networking requirements - #789
Merged
Conversation
16 tasks
mbuechse
marked this pull request as draft
October 25, 2024 19:57
kgube
marked this pull request as ready for review
November 6, 2024 11:41
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
kgube
force-pushed
the
769-kaas-networking-standard
branch
from
November 12, 2024 17:01
d9f0341 to
b31281f
Compare
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
kgube
force-pushed
the
769-kaas-networking-standard
branch
from
November 13, 2024 13:25
b31281f to
ba2b8e9
Compare
Signed-off-by: Konrad Gube <konrad.gube@cloudandheat.com>
kgube
force-pushed
the
769-kaas-networking-standard
branch
from
November 13, 2024 13:48
fa67a2f to
2e1f07d
Compare
mbuechse
reviewed
Nov 13, 2024
mbuechse
left a comment
mbuechse
left a comment
Contributor
There was a problem hiding this comment.
Looking great, only a few minor typos and nitpicks.
Co-authored-by: Matthias Büchse <matthias.buechse@cloudandheat.com> Signed-off-by: kgube <67736153+kgube@users.noreply.github.com>
mbuechse
approved these changes
Nov 13, 2024
mbuechse
left a comment
mbuechse
left a comment
Contributor
There was a problem hiding this comment.
Looking really great. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #769