fix(mqtt): split reconnect loop handler to reduce log noise#137
Merged
cayossarian merged 1 commit intomainfrom Apr 17, 2026
Merged
fix(mqtt): split reconnect loop handler to reduce log noise#137cayossarian merged 1 commit intomainfrom
cayossarian merged 1 commit intomainfrom
Conversation
Expected transient failures (OSError family — ConnectionRefusedError, socket.gaierror, TimeoutError, ssl.SSLError) now log a one-line WARNING with the exception repr instead of a full paho/stdlib traceback. Unexpected exceptions retain exc_info=True so support tickets stay actionable. Bumps version to 2.6.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exceptionhandler inSpanMqttClient._reconnect_loopinto two branches: expected transient failures (OSErrorfamily —ConnectionRefusedError,socket.gaierror,TimeoutError,ssl.SSLError) log a one-line WARNING with the exception repr; unexpected exceptions retain the full traceback viaexc_info=True.ConnectionRefusedError: [Errno 61]) no longer floods logs with paho/stdlib stack frames that carry no diagnostic signal — the exception type and errno are the full diagnostic.Rationale
Pre-change log on panel disconnect:
Every frame is paho/stdlib internals that are identical on every such failure. The last line is the only signal.
Post-change log:
Note:
ssl.SSLErroris anOSErrorsubclass and falls into the transient branch — deliberate, since SSL misconfiguration fails at setup (async_setup_entry), not at reconnect. A reconnect-time SSL failure is treated as transient alongside the other network errors.Test plan