Conversation
|
@gdgib Any chance we could get this merged soon? Would love to test it out. |
|
Thanks for asking @jeffkibuule I apparently had a small email gap in github notifications there. Didn't even see this until you asked. Even bigger thanks to @etmelvin. Nice work! |
|
@jeffkibuule let me know when you've tested this. I kinda want to hold off on a release until one of us does, and I won't have time to test before the weekend. |
|
Hey @etmelvin nice work on this. It's holding up very well so far in testing, and I appreciate the quality of the code. |
|
Hmm, I'm glad I waited. While I don't have the authentication errors I usually get with HomeAssistant warning me, after a few days, each entity is listed as unavailable at about the same cadence as it previously told me Span wasn't working at all. :( |
|
Is there a stack trace or some error logs you can provide? |
|
Also.... how many days (roughly) are we talking about here? |
|
False alarm, it's been pretty durable for the last 2 weeks. Glad it got merged. Thank you! |
Picks up span-card 37e406d which addresses four valid copilot findings on PR #12: - Truncation-fold MutationObserver switched to subtree:true with a row-touching filter so we re-attach when rows are added under any wrapper, not only on full container.innerHTML resets. - span-menu-button button now has explicit type="button" so it cannot trigger a form submission if ever placed inside a <form>. - Test suites for span-icon and truncation-fold restore their console.warn spy and ResizeObserver shim in afterEach so they don't leak across test files. 245 tests pass; bundle unchanged.
Fixes #9