Skip to content

Fix Config Flow Issues#12

Merged
gdgib merged 3 commits intoSpanPanel:mainfrom
etmelvin:main
May 4, 2023
Merged

Fix Config Flow Issues#12
gdgib merged 3 commits intoSpanPanel:mainfrom
etmelvin:main

Conversation

@etmelvin
Copy link
Copy Markdown
Contributor

@etmelvin etmelvin commented May 2, 2023

Fixes #9

  • Added the ability to provide your own access token instead of using proximity authentication
  • Fixed an issue where config flow fails on user step when reauth is needed
  • Fixed an issue where Home Assistant will discovery the same panel
  • Fixed an issue where auth flow on discovery fails on missing access token

@jeffkibuule
Copy link
Copy Markdown
Contributor

@gdgib Any chance we could get this merged soon? Would love to test it out.

@gdgib gdgib self-assigned this May 4, 2023
@gdgib gdgib added this to the 0.0.8 milestone May 4, 2023
@gdgib gdgib merged commit 257a43b into SpanPanel:main May 4, 2023
@gdgib
Copy link
Copy Markdown
Collaborator

gdgib commented May 4, 2023

Thanks for asking @jeffkibuule I apparently had a small email gap in github notifications there. Didn't even see this until you asked.

Even bigger thanks to @etmelvin. Nice work!

@gdgib
Copy link
Copy Markdown
Collaborator

gdgib commented May 4, 2023

@jeffkibuule let me know when you've tested this. I kinda want to hold off on a release until one of us does, and I won't have time to test before the weekend.

@gdgib
Copy link
Copy Markdown
Collaborator

gdgib commented May 10, 2023

Hey @etmelvin nice work on this. It's holding up very well so far in testing, and I appreciate the quality of the code.

@jeffkibuule
Copy link
Copy Markdown
Contributor

Hmm, I'm glad I waited. While I don't have the authentication errors I usually get with HomeAssistant warning me, after a few days, each entity is listed as unavailable at about the same cadence as it previously told me Span wasn't working at all. :(

@etmelvin
Copy link
Copy Markdown
Contributor Author

Is there a stack trace or some error logs you can provide?

@gdgib
Copy link
Copy Markdown
Collaborator

gdgib commented May 13, 2023

Also.... how many days (roughly) are we talking about here?

@jeffkibuule
Copy link
Copy Markdown
Contributor

False alarm, it's been pretty durable for the last 2 weeks. Glad it got merged. Thank you!

cayossarian pushed a commit that referenced this pull request Aug 16, 2025
cayossarian added a commit that referenced this pull request Apr 20, 2026
Picks up span-card 37e406d which addresses four valid copilot
findings on PR #12:
- Truncation-fold MutationObserver switched to subtree:true with a
  row-touching filter so we re-attach when rows are added under any
  wrapper, not only on full container.innerHTML resets.
- span-menu-button button now has explicit type="button" so it
  cannot trigger a form submission if ever placed inside a <form>.
- Test suites for span-icon and truncation-fold restore their
  console.warn spy and ResizeObserver shim in afterEach so they
  don't leak across test files.

245 tests pass; bundle unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error during zeroconf setup (was: Testing authentication)

3 participants