Skip to content

Open Iterable<Placeholder>.joinQuoted() function#928

Merged
alexander-yevsyukov merged 10 commits into
masterfrom
open-join-quoted
May 16, 2026
Merged

Open Iterable<Placeholder>.joinQuoted() function#928
alexander-yevsyukov merged 10 commits into
masterfrom
open-join-quoted

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Contributor

This PR opens function because it will be used in diagnostic messages in Validation.

Copilot AI review requested due to automatic review settings May 15, 2026 21:42
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df6d44f693

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread buildSrc/build.gradle.kts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes Iterable<Placeholder>.joinQuoted() a public extension so it can be reused for validation/diagnostic messages, while also performing routine snapshot/version and documentation report updates.

Changes:

  • Expose Iterable<Placeholder>.joinQuoted() as a public API and add KDoc for it.
  • Bump snapshot versions and regenerate dependency report artifacts under docs/dependencies/.
  • Minor build/test/docs maintenance updates (agent docs path, buildSrc test setup, .gitignore).

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
version.gradle.kts Bumps versionToPublish snapshot number.
docs/dependencies/pom.xml Updates published snapshot version in generated dependency POM.
docs/dependencies/dependencies.md Regenerates dependency report with updated snapshot version and timestamp.
CLAUDE.md Fixes agent docs TOC path to .agents/_TOC.md.
buildSrc/src/test/kotlin/io/spine/gradle/report/license/DependencyReportOutputTest.kt Simplifies setup in dependency report output tests by removing legacy-file prewrites.
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Fixes KDoc grammar and bumps compiler version constant.
buildSrc/build.gradle.kts Changes the Kotest version used for buildSrc script tests.
base/src/main/kotlin/io/spine/string/TemplateStringExts.kt Makes joinQuoted() public and documents it.
.gitignore Ignores Claude worktree files under /.claude/worktrees/.

Comment thread base/src/main/kotlin/io/spine/string/TemplateStringExts.kt Outdated
Comment thread base/src/main/kotlin/io/spine/string/TemplateStringExts.kt
Comment thread buildSrc/build.gradle.kts Outdated
Copilot AI review requested due to automatic review settings May 15, 2026 21:52
@alexander-yevsyukov alexander-yevsyukov self-assigned this May 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Comment thread base/src/main/kotlin/io/spine/string/TemplateStringExts.kt Outdated
Comment thread base/src/main/kotlin/io/spine/string/TemplateStringExts.kt Outdated
Copy link
Copy Markdown
Collaborator

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov Hopefully, this one will allow the migration pass.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 16, 2026 14:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

* For example, given placeholders with names `"foo"`, `"bar"`, and `"baz"`,
* this method returns:
* ```
* `foo`, `bar`, `baz`.
@alexander-yevsyukov
Copy link
Copy Markdown
Contributor Author

@armiol, I've requested the re-review because of this:

Waiting on 1 reapproval from someone other than the last pusher. Review from armiol is stale because it was submitted before the most recent code changes.

@alexander-yevsyukov alexander-yevsyukov merged commit 7008905 into master May 16, 2026
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the open-join-quoted branch May 16, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants