Open Iterable<Placeholder>.joinQuoted() function#928
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df6d44f693
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This pull request makes Iterable<Placeholder>.joinQuoted() a public extension so it can be reused for validation/diagnostic messages, while also performing routine snapshot/version and documentation report updates.
Changes:
- Expose
Iterable<Placeholder>.joinQuoted()as a public API and add KDoc for it. - Bump snapshot versions and regenerate dependency report artifacts under
docs/dependencies/. - Minor build/test/docs maintenance updates (agent docs path, buildSrc test setup,
.gitignore).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
version.gradle.kts |
Bumps versionToPublish snapshot number. |
docs/dependencies/pom.xml |
Updates published snapshot version in generated dependency POM. |
docs/dependencies/dependencies.md |
Regenerates dependency report with updated snapshot version and timestamp. |
CLAUDE.md |
Fixes agent docs TOC path to .agents/_TOC.md. |
buildSrc/src/test/kotlin/io/spine/gradle/report/license/DependencyReportOutputTest.kt |
Simplifies setup in dependency report output tests by removing legacy-file prewrites. |
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt |
Fixes KDoc grammar and bumps compiler version constant. |
buildSrc/build.gradle.kts |
Changes the Kotest version used for buildSrc script tests. |
base/src/main/kotlin/io/spine/string/TemplateStringExts.kt |
Makes joinQuoted() public and documents it. |
.gitignore |
Ignores Claude worktree files under /.claude/worktrees/. |
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov Hopefully, this one will allow the migration pass.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| * For example, given placeholders with names `"foo"`, `"bar"`, and `"baz"`, | ||
| * this method returns: | ||
| * ``` | ||
| * `foo`, `bar`, `baz`. |
|
@armiol, I've requested the re-review because of this:
|
This PR opens function because it will be used in diagnostic messages in Validation.