Skip to content

Improve Claude-related setup#656

Merged
alexander-yevsyukov merged 14 commits into
masterfrom
claude-setup
May 18, 2026
Merged

Improve Claude-related setup#656
alexander-yevsyukov merged 14 commits into
masterfrom
claude-setup

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Contributor

This PR adds agent skills and configures Claude agents per claude-code-setup recommendations.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds substantial AI-agent configuration for Claude Code (skills, slash commands, subagents, hooks) plus minor unrelated cleanups (typo in CoreJvmCompiler KDoc, Kotest 6.1.10 → 6.1.11, coding-guideline wording, README expansion). The .claude/ and .agents/skills/ trees define repo-specific workflows (version bumps, dependency updates/audits, doc reviews, Kotlin reviews, pre-PR gate, file moves, Java→Kotlin conversion), with shell hooks that protect version.gradle.kts and gate gh pr create on a /pre-pr sentinel.

Changes:

  • New .claude/ configuration: permission allowlist, PreToolUse/PostToolUse hooks (protect-version-file.sh, pre-pr-gate.sh, sanitize-kotlin.sh), slash commands, and subagents.
  • New .agents/skills/ documents (kotlin-review, review-docs, dependency-audit, dependency-update, pre-pr) plus TOC update and minor coding-guideline wording.
  • Misc: README expansion documenting AI-agent files; Kotest 6.1.11 bump; KDoc typo fix in CoreJvmCompiler.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Expands the list of files propagated by pull, adds AI-agent configuration section.
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Fixes KDoc typo ("used to in" → "used in").
buildSrc/build.gradle.kts Bumps Kotest 6.1.10 → 6.1.11.
.claude/settings.json Defines Bash permission allow/deny/ask lists and registers Pre/PostToolUse hooks.
.claude/scripts/sanitize-kotlin.sh PostToolUse hook stripping trailing whitespace and collapsing blank lines in Kotlin/Java sources.
.claude/scripts/protect-version-file.sh PreToolUse hook blocking direct edits to version.gradle.kts.
.claude/scripts/pre-pr-gate.sh PreToolUse hook blocking gh pr create until /pre-pr writes a fresh sentinel.
.claude/commands/*.md Slash commands that delegate to the matching .agents/skills/*/SKILL.md.
.claude/agents/*.md Subagents (kotlin-review, review-docs, dependency-audit) wired to their skills.
.agents/skills/*/SKILL.md Authoritative skill definitions for review/audit/update/pre-pr workflows.
.agents/skills/dependency-update/agents/openai.yaml OpenAI agent display metadata for the dependency-update skill.
.agents/coding-guidelines.md Sharper wording for the double-empty-line rule.
.agents/_TOC.md Adds entries for the new skills.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread .claude/scripts/sanitize-source-code.kt
Comment thread .claude/scripts/pre-pr-gate.sh
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 689bc809bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/scripts/sanitize-source-code.kt
Comment thread .claude/commands/pre-pr.md Outdated
@alexander-yevsyukov alexander-yevsyukov merged commit b8c2b03 into master May 18, 2026
3 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the claude-setup branch May 18, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants