Improve integration tests of the (when) option compilation#195
Draft
alexander-yevsyukov wants to merge 7 commits into
Draft
Improve integration tests of the (when) option compilation#195alexander-yevsyukov wants to merge 7 commits into
(when) option compilation#195alexander-yevsyukov wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
The PR title declares improvements to integration tests of the (when) option compilation, but the diff contains a much broader set of changes: a Gradle wrapper upgrade with a rewritten gradlew.bat, two new .agents skills (bump-version, bump-gradle) and a rewritten version-policy.md, relocation of dependency reports to docs/dependencies/ with a new DependencyReportOutputTest, refactored ErrorPlaceholder imports across WhenOption, WhenGenerator, and LocalDateValidator, and version bumps for Validation, Time, CoreJvmCompiler, and the project itself. No new or updated (when) integration tests are visible.
Changes:
- Updated
ErrorPlaceholderimports (and switchedRuntimeErrorPlaceholder→ErrorPlaceholderinLocalDateValidator). - Bumped Gradle wrapper to 9.5.1, rewrote
gradlew.bat, and updated agents/skills documentation. - Moved dependency reports under
docs/dependencies/with a new buildSrc test.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Snapshot version bump 240→241 |
| validation/.../WhenOption.kt | Re-grouped ErrorPlaceholder imports under io.spine.validation |
| validation/.../WhenGenerator.kt | Same import refactoring |
| time/.../LocalDateValidator.kt | Switched runtime placeholder type — needs verification |
| gradlew.bat | Rewritten error-handling flow (suspect missing termination after error paths) |
| gradlew | Updated source-template URL comment |
| gradle/wrapper/gradle-wrapper.properties | Bumped Gradle to 9.5.1; added retries=0/retryBackOffMs |
| CLAUDE.md | Fixed TOC path to .agents/_TOC.md |
| buildSrc/.../DependencyReportOutputTest.kt | New tests for report output location |
| buildSrc/.../PomGenerator.kt | Writes pom under docs/dependencies/; no longer deletes prior file |
| buildSrc/.../Paths.kt | Added outputDirectory and outputFile() helpers |
| buildSrc/.../LicenseReporter.kt | Writes merged report under docs/dependencies/ |
| buildSrc/.../Validation.kt | Version bump 414→421 |
| buildSrc/.../Time.kt | Version bump 238→240 |
| buildSrc/.../CoreJvmCompiler.kt | Version bumps for dogfooding/IT |
| .gitignore | Ignore /.claude/worktrees/ |
| .github/workflows/ensure-reports-updated.yml | Step renamed |
| .agents/version-policy.md | Rewritten to point at bump-version skill |
| .agents/skills/writer/SKILL.md | Added typographic-quote guidance |
| .agents/skills/bump-version/{SKILL.md,agents/openai.yaml} | New skill |
| .agents/skills/bump-gradle/{SKILL.md,agents/openai.yaml} | New skill |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other notable changes
configwas applied.