Skip to content

fix(docs): resolve accessibility report issues #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dancormier wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −6
Open

fix(docs): resolve accessibility report issues #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e3a6b5
fix(docs): resolve accessibility report issues
dancormier May 20, 2026
00146ef
Merge branch 'main' into dcormier/docs-a11y-report-fixes
dancormier May 20, 2026
cca1997
Merge branch 'main' into dcormier/docs-a11y-report-fixes
dancormier May 26, 2026
deb2432
Merge branch 'main' into dcormier/docs-a11y-report-fixes
asblanco Jun 22, 2026
bace58c
Merge branch 'main' into dcormier/docs-a11y-report-fixes
asblanco Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/stacks-docs/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ h1 {
list-style: none;
}
.docs-link {
color: var(--theme-link-color, var(--black-600));

@asblanco asblanco Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated markdown prose links still seem to inherit the lower-contrast paragraph color. addDocClasses gives paragraphs docs-copy and anchors docs-link, and the existing .docs-copy .docs-link { color: inherit; } rule is more specific than this new .docs-link rule. That means links like the Popper.js example stay on the inherited paragraph color instead of using --theme-link-color / --black-600.

Could we either remove/update the earlier inherited-color rule, or include the prose selector here so it wins?

Suggested change
color: var(--theme-link-color, var(--black-600));
.docs-copy .docs-link,
.docs-link {
color: var(--theme-link-color, var(--black-600));
font-weight: 500;
}

font-weight: 500;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-docs/src/components/BannerPreview.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
<strong>Stacks is currently frozen in read-only mode.</strong> Contact the team to restore access.
</span>
<div class="s-banner--actions">
<button type="button" class="s-link s-banner--dismiss"><Icon src={IconCross} /></button>
<button type="button" class="s-link s-banner--dismiss" aria-label="Dismiss banner"><Icon src={IconCross} /></button>
</div>
</aside>
2 changes: 1 addition & 1 deletion packages/stacks-docs/src/components/ClassTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
{:else}
{@const val = String((row as Record<string, unknown>)[col] ?? '')}
{#if val === 'N/A'}
<span class="fc-black-350">N/A</span>
<span class="fc-black-400">N/A</span>
{:else if val.startsWith('.')}
<code>{val}</code>
{:else}
Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-docs/src/docs/public/system/base/overflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ description: Atomic overflow classes allow you to change an element's overflow p
```

<Example>
<div class="overflow-x-auto d-grid grid__3 sm:grid__2 md:grid__3 lg:grid__2 g16 fs-caption ff-mono pb64" tabindex="0">
<div class="overflow-x-auto d-grid grid__3 sm:grid__2 md:grid__3 lg:grid__2 g16 fs-caption ff-mono pb64" tabindex="0" role="region" aria-label="Overflow examples">
<div>
<div class="mb4">.overflow-auto</div>
<div class="ba bc-black-225 pt32 hs2 overflow-auto">
Expand Down
4 changes: 3 additions & 1 deletion packages/stacks-docs/src/docs/public/system/components/buttons.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ Each button class has a selected state which can be visually activated by applyi
</script>
```

<ToggleButtonDemo />
<Example>
<ToggleButtonDemo />
</Example>

## Additional styles

Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<Button href="#" class="ws-nowrap" {variant} {weight}>Ask question</Button>
</td>
<td class="va-middle ta-center px4">
<Button href="#" class="ws-nowrap" {variant} {weight} selected aria-pressed="true">Ask question</Button>
<Button href="#" class="ws-nowrap" {variant} {weight} selected role="button" aria-pressed="true">Ask question</Button>
</td>
<td class="va-middle ta-center px4">
<Button href="#" class="ws-nowrap" {variant} {weight} disabled>Ask question</Button>
Expand Down
2 changes: 1 addition & 1 deletion packages/stacks-docs/src/routes/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
>
<Icon src={icons[category.title]} />
<h2 class="mt-auto fs-headline1 mb12">{category.title}</h2>
<p class="mb0 fs-body2 fc-black-300">{category.description}</p>
<p class="mb0 fs-body2 fc-black-250 d:fc-black-400">{category.description}</p>
</a>
{/each}

Expand Down
Loading