Skip to content

Fix test op for object equality and order #39#43

Merged
warpech merged 1 commit into
Starcounter-Jack:masterfrom
sonnyp:#39-2
Aug 21, 2014
Merged

Fix test op for object equality and order #39#43
warpech merged 1 commit into
Starcounter-Jack:masterfrom
sonnyp:#39-2

Conversation

@sonnyp
Copy link
Copy Markdown
Contributor

@sonnyp sonnyp commented Jun 20, 2014

Fixes #39

Performances:

Running json-patch.html test on Chrome 33.0.1750.152 on Intel Mac OS X 10_9_3

no additional tests:

before

should Test Operation 433545 ops/sec

after

``should Test Operation 556552 ops/sec`

with additional tests (except test L:67)

before:

should Test Operation 431203 ops/sec

after:

should Test Operation 590440 ops/sec

Comment thread src/json-patch.ts
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn IE8 👎

Maybe a separate file should be provided with polyfills for IE8 so you don't have to load the code if you don't want to?

@sonnyp
Copy link
Copy Markdown
Contributor Author

sonnyp commented Aug 21, 2014

Any chance we can land this and close #39 ?

@warpech
Copy link
Copy Markdown
Collaborator

warpech commented Aug 21, 2014

Will do, sorry for delay!

@sonnyp
Copy link
Copy Markdown
Contributor Author

sonnyp commented Aug 21, 2014

@warpech no worry, thanks!

@warpech warpech merged commit 89f7ac3 into Starcounter-Jack:master Aug 21, 2014
@sonnyp sonnyp deleted the #39-2 branch August 29, 2014 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test op will fail if 2 objects are ordered differently

2 participants